Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSVR-249] 환경변수 관리를 위한 AWS Secret Manger 도입 #178

Closed
wants to merge 43 commits into from

Conversation

pminsung12
Copy link
Collaborator

@pminsung12 pminsung12 commented Aug 28, 2024

📌 개요 (필수)

  • 환경변수 관리를 위한 AWS Secret Manger 도입

🔨 작업 사항 (필수)


⚡️ 관심 리뷰 (선택)

  • x

🌱 연관 내용 (선택)

  • dev ec2와 prod ec2에 aws cli 설치해야함!
  • 이제 프로젝트 실행시킬 때 aws secret manager과 연동을 해야하기 때문에 로컬에 aws cli를 설치해야함. (난 brew로 설치함)
  • AWS cil가 설치되었으면, 명령어를 입력하여 인증 정보를 등록해줍니다. (참고)
  • accessKey와 secret key는 컨플에 있는 aws s3 accesskey, secretkey와 동일!
$ aws configure  

AWS Access Key ID [None]: 발급 받은 Access Key 
AWS Secret Access Key [None]: 발급 받은 Secret Access Key 
Default region name [None]: us-west-2 
Default output format [None]: json

💻 실행 화면 (필수)

  • api 정상작동!

image

@pminsung12 pminsung12 added the ❌ do not merge 아직 merge하면 안되는 상태 label Aug 28, 2024
@pminsung12 pminsung12 self-assigned this Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

Test Results

1 tests   - 52   0 ✅  - 53   0s ⏱️ -4s
1 suites  - 17   0 💤 ± 0 
1 files    - 17   1 ❌ + 1 

For more details on these failures, see this check.

Results for commit 777c246. ± Comparison against base commit eeca5ac.

This pull request removes 52 tests.
org.depromeet.spot.domain.common.HexCodeTest ‑ 유효한_값으로_헥사코드를_생성할_수_있다()
org.depromeet.spot.domain.common.HexCodeTest ‑ 주어진_값이_6글자가_아니라면_예외를_반환한다()
org.depromeet.spot.domain.common.HexCodeTest ‑ 주어진_값이_null이라면_예외를_반환한다()
org.depromeet.spot.domain.common.HexCodeTest ‑ 주어진_값이_헥사코드_범위가_아니라면_예외를_반환한다()
org.depromeet.spot.domain.media.MediaTest ‑ fileName이_null이면_미디어를_생성할_수_없다()
org.depromeet.spot.domain.media.MediaTest ‑ fileName이_공백이면_미디어를_생성할_수_없다()
org.depromeet.spot.domain.media.MediaTest ‑ url이_null이면_미디어를_생성할_수_없다()
org.depromeet.spot.domain.media.MediaTest ‑ url이_공백이면_미디어를_생성할_수_없다()
org.depromeet.spot.domain.media.extension.ImageExtensionTest ‑ value로_리뷰_미디어_확장자를_찾을_수_있다()
org.depromeet.spot.domain.media.extension.ImageExtensionTest ‑ 유효하지_않은_value로_좌석_미디어_확장자를_찾을_수_없다()
…

♻️ This comment has been updated with latest results.

@pminsung12
Copy link
Collaborator Author

로컬에 aws-cli를 이용하는 방법은 deploy나 local에서 개발할 때는 유용하지만.. github actions 상에서 build할 때가 문제가 생긴다. 그냥 config 파일을 만들자..!

@github-actions github-actions bot added size/L and removed size/M labels Sep 5, 2024
@pminsung12
Copy link
Collaborator Author

java sdk를 사용하니 로컬에서는 잘 작동하지만 reviewliketest에서 bean 중복 오류가 뜬다.. 일단 브랜치 새로 파서 보편적인 방법으로 다시 시도할게

@pminsung12
Copy link
Collaborator Author

v2 - #187

@pminsung12 pminsung12 closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❌ do not merge 아직 merge하면 안되는 상태 size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant