Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Add TypeCheck as strict under Updater Ecosystem under Update #11436

Merged
merged 9 commits into from
Jan 30, 2025

Conversation

thavaahariharangit
Copy link
Contributor

@thavaahariharangit thavaahariharangit commented Jan 29, 2025

What are you trying to accomplish?

Added type check to updater/bin/update_files.rb

Anything you want to highlight for special attention from reviewers?

I have added .github folder to sorbet check ignore list.

How will you know you've accomplished your goal?

Ran sorbet locally and it passed

hariharanthavachelvam@MacBookPro dependabot-core % bundle exec srb tc -a
No errors! Great job.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@thavaahariharangit thavaahariharangit requested a review from a team as a code owner January 29, 2025 09:50
@thavaahariharangit thavaahariharangit merged commit aa8e19a into main Jan 30, 2025
124 of 128 checks passed
@thavaahariharangit thavaahariharangit deleted the harry/sorbet-typing-updater-bin branch January 30, 2025 13:22
robaiken added a commit that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants