Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes [weekly 5k] [maven] Excon error ending up as unknown errors #11431

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Fixes [weekly 5k] [maven] Excon error ending up as unknown errors #11431

merged 2 commits into from
Jan 29, 2025

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Jan 29, 2025 •
edited
Loading

What are you trying to accomplish?

Adds more suitable error handler for Excon type registry failure errors.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Jan 29, 2025
@github-actions github-actions bot added the L: java:maven Maven packages via Maven label Jan 29, 2025
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/excon-error-socket branch 3 times, most recently from 2f02776 to fada625 Compare January 29, 2025 03:29
@sachin-sandhu sachin-sandhu marked this pull request as ready for review January 29, 2025 12:17
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner January 29, 2025 12:17
@sachin-sandhu sachin-sandhu marked this pull request as draft January 29, 2025 13:01
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/excon-error-socket branch 2 times, most recently from 651e3e7 to 3f2221e Compare January 29, 2025 15:15
@sachin-sandhu sachin-sandhu changed the title Adds error handler for registry errors Fixes [weekly 5k] [maven] Excon error ending up as unknown errors Jan 29, 2025
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/excon-error-socket branch from 3f2221e to 82d45de Compare January 29, 2025 15:17
@sachin-sandhu sachin-sandhu marked this pull request as ready for review January 29, 2025 15:22
markhallen
markhallen previously approved these changes Jan 29, 2025
View reviewed changes
@sachin-sandhu sachin-sandhu merged commit a665aea into main Jan 29, 2025
65 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/excon-error-socket branch January 29, 2025 15:42
sachin-sandhu added a commit that referenced this pull request Jan 31, 2025
@sachin-sandhu @markhallen
Fixes [weekly 5k] [maven] Excon error ending up as unknown errors (#1…
5833e2b 
…1431)

* Adds error handler for registry errors

* Update maven/lib/dependabot/maven/update_checker/version_finder.rb

Co-authored-by: Mark Allen <[email protected]>

---------

Co-authored-by: Mark Allen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markhallen markhallen markhallen approved these changes

Assignees

@sachin-sandhu sachin-sandhu

Labels
L: java:maven Maven packages via Maven
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachin-sandhu @markhallen