prefer SafeVersions property when considering other versions
#11312
+161
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-update-analysis-limits
branch
3 times, most recently
from
86ff02a to
8e0b59b
Compare
brettfo
commented
Jan 16, 2025
| var prereleaseTypeMatches = currentVersion is null || !currentVersion.IsPrerelease || !version.IsPrerelease || version.Version == currentVersion.Version; | ||
| var isIgnoredVersion = dependencyInfo.IgnoredVersions.Any(i => i.IsSatisfiedBy(version)); | ||
| var isVulnerableVersion = dependencyInfo.Vulnerabilities.Any(v => v.IsVulnerable(version)); | ||
| var isSafeVersion = !safeVersions.Any() || safeVersions.Any(s => s.IsSatisfiedBy(version)); |
There was a problem hiding this comment.
This is the new check. If no explicit safe versions are specified, the behavior remains unchanged. If there are, make sure one of them matches.
brettfo
changed the title
SafeVersions property before considering other version restrictionsSafeVersions property when considering other versions
sebasgomez238
approved these changes
Jan 17, 2025
randhircs
force-pushed
the
dev/brettfo/nuget-update-analysis-limits
branch
from
8e0b59b to
57b57a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also consider a security advisory's explicit safe versions when evaluating package updates.
The lambda version filter was rewritten to make it easier to read and debug because there are several places to set a breakpoint. The only functional change is the additional explicit check in the
SafeVersionsproperty at the end.The run worker was also updated to generate the correct
DependencyInfoobject from theSecurityAdvisorys from the job file.Fixes #11311.