Refactor pnpm updater to handle devDependencies and optimize update logic #11304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR refactors the
pnpm updater
logic to improve how it handlesdevDependencies
and other dependencies. The changes include:ToolFeatureNotSupported
error for dependencies that are part ofworkspaces-devDependencies
since we currently do not supportdevDependencies
in workspaces.devDependencies
and other dependencies for updates.--save-dev
flag specifically fordevDependencies
.pnpm install
when an experimental flag is enabled.This resolves potential issues where unsupported dependencies in workspaces caused unclear errors and optimizes dependency management.
Anything you want to highlight for special attention from reviewers?
ToolFeatureNotSupported
error forworkspaces-devDependencies
ensures better clarity for users and aligns with the current limitations of our tool.devDependencies
with the--save-dev
flag is welcome.pnpm install
under the experimental flag, suggestions are appreciated.How will you know you've accomplished your goal?
ToolFeatureNotSupported
error for unsupportedworkspaces-devDependencies
.devDependencies
and other dependencies are correctly updated with their respective flags.enable_fix_for_pnpm_no_change_error
.lockfile
changes behave as expected under different scenarios, including unsupported workspace dependencies.Checklist