Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(crypto): clarify doc comment #6368

Merged
merged 1 commit into from
Jan 30, 2025
Merged

docs(crypto): clarify doc comment #6368

merged 1 commit into from
Jan 30, 2025

Conversation

heydamianc
Copy link
Contributor

@heydamianc heydamianc commented Jan 28, 2025

This just clarifies the documentation.

@heydamianc heydamianc requested a review from kt3k as a code owner January 28, 2025 05:39
@CLAassistant
Copy link

CLAassistant commented Jan 28, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (f30741c) to head (6f4cc4a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6368   +/-   ##
=======================================
  Coverage   96.31%   96.32%           
=======================================
  Files         553      553           
  Lines       41973    41973           
  Branches     6360     6360           
=======================================
+ Hits        40426    40430    +4     
+ Misses       1507     1503    -4     
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Can you sign the CLA from the above link?

@kt3k kt3k changed the title Clarify doc comment docs(crypto): clarify doc comment Jan 28, 2025
@heydamianc
Copy link
Contributor Author

Hi @kt3k, I believe I completed all the necessary requirements for this change. Thanks for your help.

@kt3k kt3k merged commit 61ee836 into denoland:main Jan 30, 2025
18 of 20 checks passed
@kt3k
Copy link
Member

kt3k commented Jan 30, 2025

Thanks for your contribution!

@heydamianc heydamianc deleted the patch-1 branch January 30, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants