Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(expect): fix typo on objectContaining example #6356

Conversation

rogerpoliver
Copy link
Contributor

Hi, I was reading the documentation for expect.objectContaining and noticed a mistake in the example.

The first expectation is incorrect because the expected value for the key bar does not match the actual value. I've updated the example to reflect the correct behavior.

@rogerpoliver rogerpoliver requested a review from kt3k as a code owner January 22, 2025 04:10
@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (5af091b) to head (925d203).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6356   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files         552      552           
  Lines       41938    41938           
  Branches     6354     6354           
=======================================
  Hits        40399    40399           
+ Misses       1499     1498    -1     
- Partials       40       41    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rogerpoliver rogerpoliver deleted the fix-expect-object-containing-example branch January 22, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants