Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use native type stripping of Node.js in node testing #6339

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jan 10, 2025

This PR starts using native type strip feature of Node.js to run tests in Node, and it fixes the CI on main.

This PR also does some clean ups.

  • You can now directly execute deno task test:node without running npm install in _tools/node_test_runner dir beforehand.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (148107e) to head (4caba86).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6339      +/-   ##
==========================================
+ Coverage   96.34%   96.43%   +0.09%     
==========================================
  Files         547      547              
  Lines       41755    41788      +33     
  Branches     6327     6338      +11     
==========================================
+ Hits        40228    40300      +72     
+ Misses       1486     1447      -39     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k mentioned this pull request Jan 10, 2025
2 tasks
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 6cf1eea into denoland:main Jan 10, 2025
20 checks passed
@kt3k kt3k deleted the chore-use-native-ts-execution-of-node branch January 10, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants