Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(expect,text): remove no-eval directives that appear to be unneccessary #6333

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

finleyjb
Copy link
Contributor

@finleyjb finleyjb commented Jan 5, 2025

Per #5728, we want to review the usage of no-eval.

These examples pass with no-eval removed, so we might as well remove them.

$ deno task test text/unstable_slugify.ts                                                                                                                                                                                                                                                                          
Task test deno test --unstable-http --unstable-webgpu --doc --allow-all --parallel --coverage --trace-leaks --clean "text/unstable_slugify.ts"
Check file:///home/fin/src/std/text/unstable_slugify.ts
Check file:///home/fin/src/std/text/unstable_slugify.ts$25-31.ts
Check file:///home/fin/src/std/text/unstable_slugify.ts$37-43.ts
Check file:///home/fin/src/std/text/unstable_slugify.ts$49-55.ts
Check file:///home/fin/src/std/text/unstable_slugify.ts$61-67.ts
Check file:///home/fin/src/std/text/unstable_slugify.ts$80-87.ts
Check file:///home/fin/src/std/text/unstable_slugify.ts$89-97.ts
./text/unstable_slugify.ts$61-67.ts => file:///home/fin/src/std/text/unstable_slugify.ts$61-67.ts ... ok (1ms)
./text/unstable_slugify.ts$37-43.ts => file:///home/fin/src/std/text/unstable_slugify.ts$37-43.ts ... ok (3ms)
./text/unstable_slugify.ts$49-55.ts => file:///home/fin/src/std/text/unstable_slugify.ts$49-55.ts ... ok (9ms)
./text/unstable_slugify.ts$80-87.ts => file:///home/fin/src/std/text/unstable_slugify.ts$80-87.ts ... ok (9ms)
./text/unstable_slugify.ts$25-31.ts => file:///home/fin/src/std/text/unstable_slugify.ts$25-31.ts ... ok (13ms)
./text/unstable_slugify.ts$89-97.ts => file:///home/fin/src/std/text/unstable_slugify.ts$89-97.ts ... ok (8ms)

ok | 6 passed | 0 failed (63ms)
Task test deno test --unstable-http --unstable-webgpu --doc --allow-all --parallel --coverage --trace-leaks --clean "expect/expect.ts"
Check file:///home/fin/src/std/expect/expect.ts
Check file:///home/fin/src/std/expect/expect.ts$122-133.ts
Check file:///home/fin/src/std/expect/expect.ts$251-296.ts
Check file:///home/fin/src/std/expect/expect.ts$305-355.ts
Check file:///home/fin/src/std/expect/expect.ts$362-371.ts
Check file:///home/fin/src/std/expect/expect.ts$381-395.ts
Check file:///home/fin/src/std/expect/expect.ts$411-421.ts
Check file:///home/fin/src/std/expect/expect.ts$436-449.ts
Check file:///home/fin/src/std/expect/expect.ts$459-470.ts
Check file:///home/fin/src/std/expect/expect.ts$485-495.ts
Check file:///home/fin/src/std/expect/expect.ts$506-516.ts
Check file:///home/fin/src/std/expect/expect.ts$525-535.ts
Check file:///home/fin/src/std/expect/expect.ts$544-552.ts
Check file:///home/fin/src/std/expect/expect.ts$573-596.ts
Check file:///home/fin/src/std/expect/expect.ts$611-617.ts
./expect/expect.ts$305-355.ts => file:///home/fin/src/std/expect/expect.ts$305-355.ts ... ok (2ms)
./expect/expect.ts$411-421.ts => file:///home/fin/src/std/expect/expect.ts$411-421.ts ... ok (1ms)
./expect/expect.ts$362-371.ts => file:///home/fin/src/std/expect/expect.ts$362-371.ts ... ok (1ms)
./expect/expect.ts$381-395.ts => file:///home/fin/src/std/expect/expect.ts$381-395.ts ... ok (1ms)
./expect/expect.ts$459-470.ts => file:///home/fin/src/std/expect/expect.ts$459-470.ts ... ok (3ms)
./expect/expect.ts$506-516.ts => file:///home/fin/src/std/expect/expect.ts$506-516.ts ... ok (4ms)
./expect/expect.ts$122-133.ts => file:///home/fin/src/std/expect/expect.ts$122-133.ts ... ok (2ms)
./expect/expect.ts$544-552.ts => file:///home/fin/src/std/expect/expect.ts$544-552.ts ... ok (2ms)
./expect/expect.ts$611-617.ts => file:///home/fin/src/std/expect/expect.ts$611-617.ts ... ok (2ms)
./expect/expect.ts$251-296.ts => file:///home/fin/src/std/expect/expect.ts$251-296.ts ... ok (1ms)
./expect/expect.ts$436-449.ts => file:///home/fin/src/std/expect/expect.ts$436-449.ts ... ok (3ms)
./expect/expect.ts$485-495.ts => file:///home/fin/src/std/expect/expect.ts$485-495.ts ... ok (2ms)
./expect/expect.ts$573-596.ts => file:///home/fin/src/std/expect/expect.ts$573-596.ts ... ok (3ms)
./expect/expect.ts$525-535.ts => file:///home/fin/src/std/expect/expect.ts$525-535.ts ... ok (6ms)

ok | 14 passed | 0 failed (242ms)

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (e3dc30a) to head (8f193a5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6333      +/-   ##
==========================================
- Coverage   96.35%   96.34%   -0.01%     
==========================================
  Files         547      547              
  Lines       41671    41671              
  Branches     6315     6315              
==========================================
- Hits        40151    40148       -3     
- Misses       1479     1482       +3     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@kt3k kt3k changed the title docs: Remove no-eval directives that appear to be unneccessary docs(expect,text): remove no-eval directives that appear to be unneccessary Jan 6, 2025
@kt3k kt3k merged commit 568cc75 into denoland:main Jan 6, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants