fix(node): show directory import and missing extension suggestions #27905
+418
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Feb 1, 2025
| @@ -143,6 +144,39 @@ impl NodeResolution { | |||
| } | |||
| } | |||
|
|
|||
| struct LocalPath { | |||
| } | ||
| } | ||
| LocalUrlOrPath::Path(LocalPath { path, known_exists }) => { | ||
| if known_exists { |
There was a problem hiding this comment.
As part of this change, we do the finalize_resolution step when resolving npm specifiers too (so that these better errors can happen and so the node resolution code is always using the same path). I was concerened about the extra fs hit that brings, so I updated the code to also keep track of whether we know a path exists in order to avoid the finalization check if the path is known to exist.
|
Would it be okay to close the below PR due to this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows directory import and missing extension suggestions in error messages similar but not exactly to node.