feat(outdated): interactive update #27812
Conversation
nathanwhit
force-pushed
the
interactive-update
branch
from
3df1283 to
4f71a95
Compare
nathanwhit
force-pushed
the
interactive-update
branch
from
4f71a95 to
bca1b57
Compare
| out.flush()?; | ||
|
|
||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
It might be better to switch this to https://github.com/dsherret/console_static_text with deno_terminal because then we don't need the crossterm dependency. Additionally, console_static_text is already used by the draw thread for progress bars: https://github.com/denoland/deno/blob/main/cli/util/draw_thread.rs and in the future we could hook it up so that you can do stuff like show progress bars at the same time as having interaction https://david.deno.dev/posts/console-static-text/
That said, we probably still want something for handling key presses though... maybe the repl has some code that does that? Otherwise I guess we need to use crossterm.
There was a problem hiding this comment.
The repl uses rustyline which has its own keypress handling AFAICT.
Did a quick check, this PR adds about 66 KiB to the binary - though not sure how much of that is crossterm. It does also add an extra version of mio to our dependency tree because we're on an old tokio version – though when we upgrade tokio it'll remove that duplication
There was a problem hiding this comment.
For unix it probably wouldn't be too hard to roll our own, but no idea about windows
There was a problem hiding this comment.
I think at least here we should use deno_terminal and console_static_text to prevent having multiple implementations ending up in the executable. Maybe something for a follow-up though.
There was a problem hiding this comment.
For deno_terminal, it would help us re-use the logic we have for NO_COLOR and TERM styling, but I think crossterm handles that as well: https://github.com/denoland/deno_terminal/blob/main/src/colors.rs
| major: u64, | ||
| minor: u64, | ||
| patch: u64, | ||
| pre: Option<String>, |
There was a problem hiding this comment.
Should we be using deno_semver::Version here? https://docs.rs/deno_semver/0.7.1/deno_semver/struct.Version.html
WIP. This is currently just an impl for the UI part. Finishing this out should just be a matter of tweaking the UI and wiring up the inputs and outputs (though writing tests will be a tricky part)