fix: set 'npm_config_user_agent' env var when installing or running npm deps #26311

bartlomieju · 2024-10-16T13:33:29Z

…pm deps

bartlomieju · 2024-10-16T13:34:14Z

cli/tools/run/mod.rs

 pub async fn maybe_npm_install(factory: &CliFactory) -> Result<(), AnyError> {
+  std::env::set_var("npm_config_user_agent", get_npm_config_user_agent());


This is not really correct. I believe we want to set it every time we install npm packages, when executing deno run npm:<package_name> and when running deno task that calls a bin entry of a package.

For the deno run case, it feels like it might just be easiest to set it unconditionally, instead of trying to detect when an NPM package will run.

For the other two, setting it in task_runner.rs (in most of the ShellCommand impls) should do it I think. That would cover lifecycle scripts/deno install and deno task.

fix: set 'npm_config_user_agent' env var when installing or running n…

638f2dc

…pm deps

bartlomieju commented Oct 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: set 'npm_config_user_agent' env var when installing or running npm deps #26311

fix: set 'npm_config_user_agent' env var when installing or running npm deps #26311

bartlomieju commented Oct 16, 2024

bartlomieju Oct 16, 2024

nathanwhit Oct 16, 2024 •

edited

Loading

		pub async fn maybe_npm_install(factory: &CliFactory) -> Result<(), AnyError> {
		std::env::set_var("npm_config_user_agent", get_npm_config_user_agent());

fix: set 'npm_config_user_agent' env var when installing or running npm deps #26311

Are you sure you want to change the base?

fix: set 'npm_config_user_agent' env var when installing or running npm deps #26311

Conversation

bartlomieju commented Oct 16, 2024

bartlomieju Oct 16, 2024

Choose a reason for hiding this comment

nathanwhit Oct 16, 2024 • edited Loading

Choose a reason for hiding this comment

nathanwhit Oct 16, 2024 •

edited

Loading