Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inet and cidr types support #208

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

inet and cidr types support #208

wants to merge 3 commits into from

Conversation

denizzzka
Copy link
Owner

@denizzzka denizzzka commented Jan 30, 2025

Adds support for inet and cidr PG types, both IPv4 and IPv6 families

Also adds support of conversion from vibe.core.net.NetworkAddress

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 85.98%. Comparing base (f027852) to head (e8da4d3).

Files with missing lines Patch % Lines
src/dpq2/conv/net.d 0.00% 21 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   87.08%   85.98%   -1.10%     
==========================================
  Files          21       22       +1     
  Lines        1649     1670      +21     
==========================================
  Hits         1436     1436              
- Misses        213      234      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denizzzka denizzzka changed the title netadd and cidr support inet and cidr types support Jan 30, 2025
@denizzzka denizzzka marked this pull request as ready for review January 31, 2025 09:19
@denizzzka
Copy link
Owner Author

denizzzka commented Jan 31, 2025

@llucenic I completely reworked your code related to network addresses support because wire protocol turned out to be different. It would be great if you tried this PR on your project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants