Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VM] Pull Emails from CSP Tags #38407

Merged
merged 4 commits into from
Feb 3, 2025
Merged

[VM] Pull Emails from CSP Tags #38407

merged 4 commits into from
Feb 3, 2025

Conversation

johnnywilkes
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/UVEM-788

Description

  • Playbook now supports determining potential asset owner through email addresses stored in asset tags.

Must have

  • Tests
  • Documentation

@johnnywilkes johnnywilkes marked this pull request as draft January 29, 2025 21:43
@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jan 29, 2025
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_UVEM-788 January 29, 2025 21:44
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @talzich will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @johnnywilkes, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@johnnywilkes
Copy link
Contributor Author

@ShirleyDenkberg , please review

@johnnywilkes
Copy link
Contributor Author

@BigEasyJ , please review

@johnnywilkes johnnywilkes marked this pull request as ready for review January 30, 2025 20:48
johnnywilkes
johnnywilkes commented Jan 30, 2025
View reviewed changes
Packs/CortexVulnerabilityManagement/Playbooks/Cortex_VM_-_Vulnerability_Issue.yml
For Cortex XSOAR 6.13, see https://docs-cortex.paloaltonetworks.com/r/Cortex-XSOAR/6.13/Cortex-XSOAR-Administrator-Guide/Automations
For Cortex XSOAR 8 Cloud, see https://docs-cortex.paloaltonetworks.com/r/Cortex-XSOAR/8/Cortex-XSOAR-Cloud-Documentation/Scripts
For Cortex XSOAR on-prem, see https://docs-cortex.paloaltonetworks.com/r/Cortex-XSOAR/8.7/Cortex-XSOAR-On-prem-Documentation/Scripts
For Cortex.13, see https://docs-cortex.paloaltonetworks.com/r/Cortex-XSOAR/6.13/Cortex-XSOAR-Administrator-Guide/Automations
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShiratG , FYI, I created a bug for this continuing to happen. I can fix this manually if you please or we can wait the more permanent fix

@johnnywilkes
Copy link
Contributor Author

@talzich @karinafishman , this is approve from Xpanse side, please merge when possible

@ShirleyDenkberg ShirleyDenkberg self-assigned this Jan 31, 2025
@ShirleyDenkberg
Copy link
Contributor

@BigEasyJ @karinafishman @talzich Doc review completed.

@talzich talzich added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Feb 2, 2025
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/2120531

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Feb 2, 2025
@talzich talzich added the Security Approved If a contribution has been approved for merge by the security team, then this will allow a merge label Feb 3, 2025
@talzich talzich merged commit 7a5c7f2 into demisto:contrib/PaloAltoNetworks_UVEM-788 Feb 3, 2025
20 of 23 checks passed
@content-bot content-bot mentioned this pull request Feb 3, 2025
Merged
5 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

talzich pushed a commit that referenced this pull request Feb 3, 2025
@content-bot @johnnywilkes @ShirleyDenkberg
[VM] Pull Emails from CSP Tags (#38407) (#38455)
856af65 
* UVEM-788 and new screenshots

* RN

* Apply suggestions from code review



---------

Co-authored-by: johnnywilkes <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@BigEasyJ BigEasyJ BigEasyJ approved these changes

@talzich talzich talzich approved these changes

@karinafishman karinafishman Awaiting requested review from karinafishman

Assignees

@talzich talzich

@ShirleyDenkberg ShirleyDenkberg

@karinafishman karinafishman

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Security Approved If a contribution has been approved for merge by the security team, then this will allow a merge Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@johnnywilkes @content-bot @ShirleyDenkberg @talzich @BigEasyJ @karinafishman