Ys dynatrace event collector #38369
Open
Ys dynatrace event collector #38369
+911
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasBeilin
requested changes
Jan 29, 2025
Packs/Dynatrace/Integrations/Dynatrace/Dynatrace_description.md
Outdated
Show resolved
Hide resolved
Packs/Dynatrace/Integrations/Dynatrace/Dynatrace_description.md
Outdated
Show resolved
Hide resolved
JasBeilin
requested changes
Jan 29, 2025
Comment on lines
+69
to
+71
| field_mapping = { | ||
| "Audit logs": ["Audit", "timestamp"], | ||
| "APM": ["APM", "startTime"] |
There was a problem hiding this comment.
This is a bit hard for future enhancements to change, consider changing it to a pre defined dictionary, we can discuss it further.
| events_count = 0 | ||
| args = {} | ||
|
|
||
| for i in range(7): # Design says we will do at most five calls every fetch_interval so we can get more events per fetch |
There was a problem hiding this comment.
This is usually not the way we do it but getting a limit and going in loops until we get the amount of events.
|
|
||
| demisto.debug(f"Dynatrace fetch APM {i+1} times in loop. calling query with {args=}") | ||
| response = events_query(client, args, "APM") | ||
| num_events = len(response.get("events")) |
| args["apm_from"] = last_run["last_timestamp"] + 1 | ||
|
|
||
| demisto.debug(f"Dynatrace fetch APM {i+1} times in loop. calling query with {args=}") | ||
| response = events_query(client, args, "APM") |
There was a problem hiding this comment.
Suggested change
| response = events_query(client, args, "APM") | |
| response = events_query(client, args, "APM") | |
| dedup_events = [] |
| # If no events were retrieved, we retain the same last_timestamp as before, | ||
| # In cases where no events were retrieved and this is the first run (i.e., no last_run_timestamp exists), | ||
| # the query will use start_fetch_time again in the next execution. | ||
| last_run_to_save["last_timestamp"] = response.get("events")[0]["startTime"] if response["totalCount"] != 0 else (last_run.get("last_timestamp") or fetch_start_time) |
There was a problem hiding this comment.
consider the last timestamp regardless of total count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-6409
Description
Dynatrace event collector
Must have