DONT MERGE - Feature/sync account utxos #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HinsonSIDAN
commented
Apr 29, 2024
| // TODO: Testing code, remove upon finish | ||
| // utxos, err := maestroService.QueryAddressUtxos("addr_test1zptl0h0ceq3d4tgrlkqgyv2n5cwez0juj9rm63uw8nxhpv6u5ayjvx4rk9a29n2tqf4uv4nvfv2yy8tqs0kuue8luh9sczalnn") | ||
| // fmt.Printf(" err: %v\n", err) | ||
| // fmt.Printf("First utxo: %v\n", utxos[0]) |
There was a problem hiding this comment.
Uncommenting these lines can see the behaviour of the query from maestro
HinsonSIDAN
commented
Apr 29, 2024
Comment on lines
+459
to
+479
|
|
||
| func (Am *AccountManager) SyncAccountUtxos(account *models.Account) (err error) { | ||
| // tradeAccountUtxosOnchain, err := Am.MaestroService.QueryAddressUtxos(account.TradeAccountAddress) | ||
| // if err != nil { | ||
| // return errors.New("error querying trade address utxos") | ||
| // } | ||
|
|
||
| // Requirements: | ||
| // 0. Query address utxos for both trade and change account | ||
| // 1. Include all utxos missing from DB | ||
| // 2. Include all utxo value missing from DB | ||
| // 3. If account ref script not set: Sync ref script to account for the first ref script utxos identified | ||
| // 4. If account ref script set: Include additional ref script utxos as fee utxos if identified | ||
| // 5. Sync utxos to spent if they are spent | ||
|
|
||
| // Step 1: Check if tx hash exist | ||
|
|
||
| // Step 2: | ||
|
|
||
| return err | ||
| } |
There was a problem hiding this comment.
here we outline the expected behaviour of this endpoint
There was a problem hiding this comment.
For utxos
AccountUtxo -> UnspentTransaction
AccountUtxo -> UtxoValue
HinsonSIDAN
commented
Apr 29, 2024
| return utxos, nil | ||
| } | ||
| utxos = append(utxos, addressUtxos.Data...) | ||
| param.Cursor(addressUtxos.NextCursor) |
There was a problem hiding this comment.
The query we'll use for querying account utxos
|
@leuhk I handover this ticket here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP PR