Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't consume/eat the the exlaimation mark at the end of a link #85

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

Simon-Laux
Copy link
Member

closes #81

@Simon-Laux Simon-Laux added the bug Something isn't working label Jan 8, 2025
Copy link
Contributor

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the codebase and I don't know whether the runtime code is correct, and I don't know if this is in line with any kind of "link parsing specification", but I can say that Telegram behaves the same way as the tests describe.

@nicodh
Copy link

nicodh commented Jan 8, 2025

Is there an easy way to test the compiled wasm with a local desktop instance?
Is it sufficient to build it with wasm-pack and link it in the node modules?

edit: tried it but some files missed in the generated wasm package after running
"wasm-pack build --scope deltachat --target web"

@Simon-Laux
Copy link
Member Author

Simon-Laux commented Jan 8, 2025

I'd use the web example for testing instead of testing it in desktop. (it gives more information)

@nicodh
Copy link

nicodh commented Jan 9, 2025

Ok, so it will be tested when it's merged.

@Simon-Laux
Copy link
Member Author

Ok, so it will be tested when it's merged.

you can also run it locally

@Simon-Laux Simon-Laux merged commit 6c259a4 into master Jan 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copying a link from a message sometimes fails
3 participants