Add benchmarking for get_first_emoji #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
reviewed
May 28, 2024
benches/my_benchmark.rs
Outdated
Comment on lines
15
to
24
| let emojies = vec![ | ||
| "not an emoji", | ||
| "\u{3299}\u{3300}", | ||
| "🟠", | ||
| "", | ||
| "🟠y", | ||
| "🍏", | ||
| "lorem", | ||
| "😀", | ||
| ]; |
There was a problem hiding this comment.
wouldn't it make more sense to load in all of the valid emojis? or one of each range and variant, like everything from single character emoji to composite emoji with gender, skin- and hair-colour?
There was a problem hiding this comment.
Yeah I think it makes sense to add more emojies from each range.
There was a problem hiding this comment.
bigger composite emoji are still missing, like 👨👩👧👧 and 👸🏾 (grouped/joined emoji & gender + skin tone)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.