refactor: correctly use itemKey in gallery

This does not appear to have noticeable functional effect.
deltachat · Jan 12, 2025 · c1d8d57 · c1d8d57
1 parent 5c2cdbb
commit c1d8d57
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/packages/frontend/src/components/Gallery.tsx b/packages/frontend/src/components/Gallery.tsx
@@ -430,6 +430,11 @@ export default class Gallery extends Component<
                             this.openFullscreenMedia.bind(this),
                           itemsPerRow,
                         }}
+                        itemKey={({ rowIndex, columnIndex, data }) =>
+                          data.mediaMessageIds[
+                            rowIndex * itemsPerRow + columnIndex
+                          ]
+                        }
                       >
                         {GalleryGridCell}
                       </FixedSizeGrid>
@@ -475,7 +480,7 @@ function GalleryGridCell({
     return null
   }
   return (
-    <div style={{ ...style }} className='item' key={msgId}>
+    <div style={{ ...style }} className='item'>
       <Component
         messageId={msgId}
         loadResult={message}
@@ -541,6 +546,7 @@ function FileTable({
         mediaLoadResult,
         queryText,
       }}
+      itemKey={(index, data) => data.mediaMessageIds[index]}
     >
       {FileAttachmentRowWrapper}
     </FixedSizeList>
@@ -567,7 +573,7 @@ function FileAttachmentRowWrapper({
     return null
   }
   return (
-    <div style={style} className='item' key={msgId}>
+    <div style={style} className='item'>
       <FileAttachmentRow
         messageId={msgId}
         loadResult={message}