use synchronized block to avoid IllegalMonitorStateException #3526
Conversation
|
oh mannnn, all the CI actions decided to go nuts right on my PR |
|
what exactly does |
|
To test the changes in this pull request, install this apk: |
I was wondering exactly the same, that is why I was a bit skeptical when read that it is the solution to the problem in https://stackoverflow.com/a/24186147 but then I searched our code and in all other places where we use |
| try { | ||
| // The `wait()` needs to be enclosed in a while loop because there may be | ||
| // "spurious wake-ups", i.e. `wait()` may return even though `notifyAll()` wasn't called. | ||
| STOP_NOTIFIER.wait(); | ||
| synchronized (STOP_NOTIFIER) { | ||
| STOP_NOTIFIER.wait(); | ||
| } | ||
| } catch (InterruptedException ex) { } | ||
| } | ||
| } |
There was a problem hiding this comment.
According to the documentation, you're supposed to put the synchronized around the while?
There was a problem hiding this comment.
Since I can't create a suggestion here on GitHub (since it would touch unchanged lines), I just pushed a commit with my suggestion
| uses: actions/upload-artifact@v3 | ||
| uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
CI fails otherwise (v3 is deprecated)
close #3525