-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:WIP: Refactor vacuum to commit to log and add builder #669
Conversation
Can you implement this |
@Blajda it was fast, thanks! |
Hi @mrk-its, You might want to hold off on using this implementation of vacuum since the new tests show multiple issues with deleting nested partitions. It may also have integration issues with aws since we have some for Azure. |
Sure, I'm going to be super careful, for now I'm simply running it in dry-run mode.
Can you point me to the test build with these issues for nested partitions? I probably can help with tests on AWS |
This PR contains new vacuum tests for various scenarios in I might split this PR since it also contains new test code to easily test with different backends without having to worry about the clean up and setup. If you look into The main issues with vacuum right now is the |
Closing this to break it down into multiple PRs. |
Description
Pull the vacuum operation out of the Delta table and commit to the log various metrics.
The structure of this code is similar to Optimize where the operation uses a struct which has a plan and execute component.
It also introduces a builder with reasonable defaults and helps ensure that future enhancements do not break the call API.
The current call API requires the user to specify the retention interval as hours. I have changed this to use Chrono's Duration since I find it more ergonomic then implement time conversions our selves. The Databricks implementation allows the user to pass a float value for periods smaller than a day which brings us in line.
Related Issue(s)
I want to close these related issues. Let me know if there's anything else you would like to see
#97
#667
TODO