Fix get_latest_version returning version < 0. (#364)

delta-io · Aug 9, 2021 · 4fd43cb · 4fd43cb
1 parent 61e2941
commit 4fd43cb
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/rust/src/delta.rs b/rust/src/delta.rs
@@ -604,6 +604,13 @@ impl DeltaTable {
                     match e {
                         StorageError::NotFound => {
                             version -= 1;
+                            if version < 0 {
+                                let err = format!(
+                                    "No snapshot or version 0 found, perhaps {} is an empty dir?",
+                                    self.table_uri
+                                );
+                                return Err(DeltaTableError::NotATable(err));
+                            }
                         }
                         _ => return Err(DeltaTableError::from(e)),
                     }

diff --git a/rust/tests/read_error_test.rs b/rust/tests/read_error_test.rs
@@ -11,4 +11,16 @@ async fn read_empty_folder() {
         result.unwrap_err(),
         deltalake::DeltaTableError::NotATable(_),
     ));
+
+    let dir = env::temp_dir();
+    let result = deltalake::open_table_with_ds(
+        &dir.into_os_string().into_string().unwrap(),
+        "2021-08-09T13:18:31+08:00",
+    )
+    .await;
+
+    assert!(matches!(
+        result.unwrap_err(),
+        deltalake::DeltaTableError::NotATable(_),
+    ));
 }