Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/node-problem-detector] allow setting dnsPolicy #668

Merged
merged 4 commits into from
Jan 27, 2025
Merged

[stable/node-problem-detector] allow setting dnsPolicy #668

merged 4 commits into from
Jan 27, 2025

Conversation

BojanZelic
Copy link
Contributor

Description

Allows setting dnsPolicy for node problem detector. This is useful if users are using hostNetwork: true and are using checks that depend on their k8s dns setup (ex requires setting dnsPolicy to ClusterFirstWithHostNet)

The default value here is ClusterFirst (not Default ) - https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-s-dns-policy

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@BojanZelic BojanZelic requested a review from a team as a code owner January 24, 2025 20:32
max-rocket-internet
max-rocket-internet approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @BojanZelic 💚

@max-rocket-internet max-rocket-internet enabled auto-merge (squash) January 27, 2025 08:43
@max-rocket-internet max-rocket-internet merged commit 6b40902 into deliveryhero:master Jan 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BojanZelic @max-rocket-internet