Merge pull request #478 from defuse/fix-php8-tests

Skip a test of substr for PHP 8 and above because the behavior changed
defuse · Apr 9, 2021 · aef1bd4 · aef1bd4
2 parents 2a693cb + 54f79a1
commit aef1bd4
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/test/unit/CoreTest.php b/test/unit/CoreTest.php
@@ -79,10 +79,14 @@ public function testOurSubstrOutOfBorders()
         // See: https://secure.php.net/manual/en/function.mb-substr.php#50275
 
         // We want to be like substr, so confirm that behavior.
-        $this->assertSame(
-            false,
-            substr('abc', 5, 2)
-        );
+        if (PHP_VERSION_ID < 80000) {
+            // In PHP 8.0, substr starts returning '' instead of the empty string.
+            // Core::ourSubstr should behave the OLD way.
+            $this->assertSame(
+                false,
+                substr('abc', 5, 2)
+            );
+        }
 
         // Confirm that mb_substr does not have that behavior.
         if (function_exists('mb_substr')) {