-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add docs for wiring in pre-reqs for S3/MetalLB #1235
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, appreciate you taking the time to test this out for us! One other note we may want to add, while the examples are values
, for a prod bundle the end user would likely want variables
for connecting to cloud storage at least.
overrides: | ||
loki: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add the overrides to lock down the egress traffic to strictly what is necessary here (uds-loki-config
chart has some values for storage egress that when not specified default to egress anywhere).
overrides: | ||
velero: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here on the egress policy overrides, see the values here.
:::caution | ||
If you are using the in-cluster Minio Operator UDS Package for backups you must ensure that the volumes that back that storage are themselves backed up! Cluster or deployment issues may result in a loss of Minio as well as the application you intend to back up. | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, but I wonder if there's a better place to put this caution note given that it applies to both Loki and Velero (and is currently "nested" under the Velero section). We could just copy/paste it to Loki but that doesn't feel right 😅
loki: | ||
values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this confused me initially (especially when comparing against the minio example) - can we add the boilerplate of overrides
, package, component, etc?
velero: | ||
values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as loki on adding the boilerplate to the example.
Description
Adds some docs for S3 pre-reqs and mentions the MetalLB package
Related Issue
Fixes #N/A
Type of change
Steps to Validate
Checklist before merging