Address possible issue with skewed timestamps in system log after (re)boot with power loss #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #5 for details.
In particular: 1. Tests do not require authorization, so it has been turned off. 2. Added "Connection: close" header to all curl invocations to avoid unnecessary log warnings in the interim proxies like nginx if HTTP keepalives are enabled.
defanator
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes include additional step between collecting and submitting system log after router reboot: checking the log for possible "jump" in timestamps, which may occur in cases when a router was booted after power loss and hardware clock was unsynchronized until the NTP comes into play.
Having part of log lines marked with older timestamps makes it impossible to put such entries to loki (it accepts entries no older than an hour or so by default).
New logic involves remapping timestamps for unsynchronized lines backwards from 1st line with the very first timestamp after clock was synchronized (see tests for more details).
Intended to close #5.