-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: UT bug exposed by upgraded dpdata #1636
Conversation
WalkthroughWalkthroughThe pull request introduces a modification in the Changes
Tip Announcements
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The dpgen type_map was set to ['C', 'H', 'N'], which was not consistent with the types in the reference data. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #1636 +/- ##
=======================================
Coverage 49.54% 49.54%
=======================================
Files 83 83
Lines 14848 14848
=======================================
Hits 7357 7357
Misses 7491 7491 ☔ View full report in Codecov by Sentry. |
given type.raw
type_map.raw
with dpdata v0.2.19 |
Summary by CodeRabbit
New Features
Bug Fixes