feat: Logger util #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
requested changes
Jul 15, 2024
mofojed
requested changes
Jul 15, 2024
| info: (label, ...args) => console.info(`[${label}] INFO:`, ...args), | ||
| debug: (label, ...args) => console.debug(`[${label}] DEBUG:`, ...args), | ||
| debug2: (label, ...args) => console.debug(`[${label}] DEBUG2:`, ...args), | ||
| error: console.error.bind(console), |
There was a problem hiding this comment.
Now the label's not being printed with the square brackets. In the private handle method below, wrap the this.label in square brackets so it's printed correctly.
src/util/Toaster.ts
Outdated
Comment on lines
10
to
22
| showErrorMessage = async (message: string) => { | ||
| const response = await vscode.window.showErrorMessage( | ||
| message, | ||
| DOWNLOAD_LOGS_TEXT | ||
| ); | ||
|
|
||
| // If user clicks "Download Logs" button | ||
| if (response === DOWNLOAD_LOGS_TEXT) { | ||
| await vscode.commands.executeCommand(DOWNLOAD_LOGS_CMD); | ||
| } | ||
| }; | ||
|
|
||
| showInfoMessage = async (message: string) => { |
There was a problem hiding this comment.
I'd probably just name these messages error and info respectively, similar to our Logger class. Up to you though.
src/util/OutputChannelWithHistory.ts
Outdated
| ) { | ||
| this.name = outputChannel.name; | ||
|
|
||
| // Have to bind this explicilty since function overloads prevent using |
There was a problem hiding this comment.
Suggested change
| // Have to bind this explicilty since function overloads prevent using | |
| // Have to bind this explicitly since function overloads prevent using |
mofojed
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
resolves #33