Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Search filtering now works in PANELS #177

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Nov 14, 2024

I fixed a bug where I was setting description instead of label that was breaking built in search / filter in the "PANELS" treeview.

Testing

from deephaven import empty_table

for i in range(100):
    print(f"Making {i}")
    globals()[f"t{i}"] = empty_table(10).update(['X = i', 'Y = 10 * i'])
  • Hover the title of the PANELS tree
  • Click the search icon (magnifying glass)
  • Type the name of a variable to filter on
  • Should scroll to the variable. Clicking the filter button in the search box should actually filter the results

Copy link

github-actions bot commented Nov 14, 2024

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000005:11:27
A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅1979
should return custom settings: Empty configspassed ✅284
should return custom settings: Populated configspassed ✅118
should be able to load VSCodepassed ✅909
should only be visible when a supported file type is active: test.groovypassed ✅2884
should only be visible when a supported file type is active: test.pypassed ✅1179
A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant