Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Lazy load panels #173

Merged
merged 1 commit into from
Nov 13, 2024
Merged

feat: Lazy load panels #173

merged 1 commit into from
Nov 13, 2024

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Nov 12, 2024

Panels now lazy load the first time they are shown.

Can be tested using:

from deephaven import time_table

simple_ticking = time_table("PT2S")

simple_ticking2 = time_table("PT2S")

simple_ticking3 = time_table("PT2S")
  • simple_ticking tab should load as usual
  • Clicking simple_ticking or simple_ticking2 will show spinner the first time. Switching to another tab and back again should show what is already loaded without spinner
  • Closing tabs and re-opening from PANELS should re-open tabs

resolves #52

Base automatically changed from 151-cleanup-dhc-service to main November 13, 2024 13:45
Copy link

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000005:08:03
A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅2030
should return custom settings: Empty configspassed ✅235
should return custom settings: Populated configspassed ✅120
should be able to load VSCodepassed ✅912
should only be visible when a supported file type is active: test.groovypassed ✅3036
should only be visible when a supported file type is active: test.pypassed ✅1250
A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles marked this pull request as ready for review November 13, 2024 13:51
@bmingles bmingles merged commit 564495f into main Nov 13, 2024
4 checks passed
@bmingles bmingles deleted the 52-lazy-load-panels branch November 13, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deephaven tabs that are not active appear to be using resources
2 participants