Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Merged DhService with DhcService #170

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Nov 6, 2024

This PR consolidates DhService with DhcService. There shouldn't be any functional changes.

Copy link

github-actions bot commented Nov 6, 2024

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000004:52:28
A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅1907
should return custom settings: Empty configspassed ✅160
should return custom settings: Populated configspassed ✅116
should be able to load VSCodepassed ✅1081
should only be visible when a supported file type is active: test.groovypassed ✅2584
should only be visible when a supported file type is active: test.pypassed ✅980
A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles requested a review from mofojed November 6, 2024 15:44
@bmingles bmingles merged commit d59ed89 into main Nov 6, 2024
4 checks passed
@bmingles bmingles deleted the 151-cleanup-dhc-service branch November 6, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants