Add docstring_parser 0.16 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
reviewed
Oct 4, 2024
| @@ -19,6 +19,7 @@ java-utilities | |||
|
|
|||
| # optional autocomplete feature | |||
| jedi==0.19.1 | |||
| docstring_parser==0.16 | |||
There was a problem hiding this comment.
We typically prefer to be more lenient with our "requirements"; jedi is a special case where we have seen bad things happen with different versions, it's the only version we pin in py/server/setup.py. Do you have reason to believe that earlier versions of docstring_parer won't work? Or, that future versions of docstring_parser will be incompatible? If not, it would be preferable to not set a version (or, if you know old versions don't work, set a minimum version).
There was a problem hiding this comment.
Updated it to be >=0.16. I'm using a feature that's new in this version and there's no reason to believe that future versions would be incompatible.
devinrsmith
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docstring_parser==0.16torequirements.txt