Update deephaven-plugin to latest, fixed API breaking changes #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to confirm that the tests are passing, there is no command in docs or CI files that show how to run them. We used
python -m unittest discover test/deephaven
to try to run them (without thedeephaven
suffix, there is a package shadowing issue from the empty__init__.py
files that possibly should be removed?).We did verify that the changes work by using the current version of the plotly-express plugin and installing this wheel. The above failure looks legit, a mock maybe shouldn't be serializable, but I wasn't sure how this should go.