fixed tests

.github/workflows/build.yml

@@ -8,6 +8,26 @@ on:
     tags: [ 'v*' ]
 
 jobs:
+  test:
+    runs-on: ubuntu-22.04
+    strategy:
+      matrix:
+        python: [ "3.8", "3.9", "3.10", "3.11" ]
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Setup Python
+        uses: actions/setup-python@v4
+        with:
+          python-version: ${{ matrix.python }}
+
+      - name: Install tox
+        run: pip install tox
+
+      - name: Run tox
+        run: tox -e py
+
   build-dist:
     runs-on: ubuntu-22.04
     steps:

README.md

@@ -24,6 +24,10 @@ The wheel is stored in `dist/`.
 To test within [deephaven-core](https://github.com/deephaven/deephaven-core), note where this wheel is stored (using `pwd`, for example).
 Then, follow the directions in the [deephaven-js-plugins](https://github.com/deephaven/deephaven-js-plugins) repo.
 
+To unit test, run the following command from the root of the repo:
+```sh
+tox -e py
+```
 
 ## Usage
 Once you have the plugin installed and the server started, the recommended way to import the package mirrors plotly express:

src/deephaven/plot/express/deephaven_figure/generate.py

@@ -138,7 +138,6 @@ def col_null_mapping(
     Yields:
       tuple[str, str]: tuple of the form (column name, associated null value)
     """
-    # TODO: catch "unsupported" types
     for col in table.columns:
         if col.name in cols:
             type_ = col.data_type.j_name
@@ -172,7 +171,7 @@ def construct_min_dataframe(
 
     update_result = empty_table(1).update(update)
 
-    return dhpd.to_pandas(update_result)
+    return dhpd.to_pandas(update_result, conv_null=False)
 
 
 def get_data_cols(

test/deephaven/plot/express/BaseTest.py

@@ -20,7 +20,7 @@ def setup_exporter_mock(cls, MockExporter, MockReference):
         cls.exporter = MockExporter()
         cls.reference = MockReference()
 
-        cls.reference._index = 0
+        cls.reference.index = 0
         cls.exporter.reference.return_value = MockReference()
 
 if __name__ == '__main__':

test/deephaven/plot/express/plots/test_area.py

@@ -2,7 +2,6 @@
 
 from ..BaseTest import BaseTestCase
 
-
 class AreaTestCase(BaseTestCase):
     def setUp(self) -> None:
         from deephaven import new_table
@@ -20,11 +19,12 @@ def setUp(self) -> None:
 
     def test_basic_area(self):
         import src.deephaven.plot.express as dx
+        from deephaven.constants import NULL_INT
 
         chart = dx.area(self.source, x="X", y="Y").to_dict(self.exporter)
         plotly, deephaven = chart["plotly"], chart["deephaven"]
 
-        # pop template as we currently do not modify at
+        # pop template as we currently do not modify it
         plotly["layout"].pop("template")
 
         expected_data = [
@@ -39,9 +39,9 @@ def test_basic_area(self):
                 'orientation': 'v',
                 'showlegend': False,
                 'stackgroup': '1',
-                'x': [-2147483648],
+                'x': [NULL_INT],
                 'xaxis': 'x',
-                'y': [-2147483648],
+                'y': [NULL_INT],
                 'yaxis': 'y',
                 'type': 'scatter'}
         ]

tox.ini

@@ -0,0 +1,8 @@
+[tox]
+isolated_build = True
+
+[testenv]
+deps =
+    deephaven-server
+commands =
+    python -m unittest discover