New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE1] Send rumor state message to new WS connection #1954

Merged

sgueissa merged 1 commit into master from work-be1-stuart-send-rumorstate-to-new-ws

Jun 27, 2024

Collaborator

sgueissa commented Jun 27, 2024

In this PR, we add:

Send rumor state message in the same way as greetserver


          send rumorstate to new ws connection

b1b85cf

sgueissa requested a review from a team as a code owner

June 27, 2024 12:57

github-actions bot commented Jun 27, 2024

Pull reviewers stats

Stats of the last 30 days for popstellar:

	User	Total reviews	Time to review	Total comments
	K1li4nL 🥇	22 ▀▀▀▀	3d 30m ▀	14 ▀▀
	matteosz 🥈	7 ▀	3d 16h 5m ▀	20 ▀▀▀
	arnauds5 🥉	6 ▀	7h	4 ▀
	emonnin-epfl	5 ▀	8h 20m	8 ▀
	onsriahi14	3 ▀	1d 10h 51m	4 ▀
	quadcopterman	3 ▀	10d 7h 3m ▀▀▀	1
	1florentin	2	10d 5h 50m ▀▀▀	0
	sgueissa	2	12h 56m	5 ▀
	MariemBaccari	2	22h 39m	6 ▀
	simone-kalbermatter	2	5h 32m	0
	Kaz-ookid	1	3d 19h 13m ▀	5 ▀
^{⚡️ Pull request stats}

sonarcloud bot commented Jun 27, 2024

Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Jun 27, 2024

Quality Gate failed for 'PoP - Be1-Go'

Failed conditions
35.7% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

sonarcloud bot commented Jun 27, 2024

Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Jun 27, 2024

Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sgueissa enabled auto-merge

June 27, 2024 13:08

arnauds5 approved these changes

View reviewed changes

Collaborator

arnauds5 left a comment

lgtm

K1li4nL added the be1-go label

K1li4nL approved these changes

View reviewed changes

sgueissa added this pull request to the merge queue

Merged via the queue into master with commit 5fd2e1c

17 of 18 checks passed

sgueissa deleted the work-be1-stuart-send-rumorstate-to-new-ws branch

June 27, 2024 13:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels