Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added copy button in RollCall QR Token fragment #1949

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

Kaz-ookid
Copy link
Contributor

addressing #1916

Added a copy to clipboard button next to the Token hash

image

@Kaz-ookid Kaz-ookid requested a review from a team as a code owner June 26, 2024 21:36
@Kaz-ookid Kaz-ookid self-assigned this Jun 26, 2024
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
20
▀▀▀▀
3d 19h 31m
14
▀▀▀
arnauds5
🥈
6
7h
4
emonnin-epfl
🥉
5
8h 20m
8
▀▀
matteosz
4
2d 1h 15m
8
▀▀
onsriahi14
3
1d 10h 51m
4
sgueissa
2
6h 58m
5
MariemBaccari
2
22h 39m
6
simone-kalbermatter
2
5h 32m
0
1florentin
1
19d 1h 53m
▀▀▀▀▀
0
quadcopterman
1
10d 7h 3m
▀▀▀
0
⚡️ Pull request stats

Copy link

🟠 There seems to be some formatting issues that must be applied from PR #1950 first.

@Kaz-ookid Kaz-ookid linked an issue Jun 26, 2024 that may be closed by this pull request
Copy link

🟠 There seems to be some formatting issues that must be applied from PR #1950 first.

…me-roll-call-attendee-copy-button

Fixes by auto-format action
matteosz
matteosz previously approved these changes Jun 27, 2024
Copy link
Contributor

@matteosz matteosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You can even leave those spaces there it's not a big deal, the rest looks great

Comment on lines 3366 to 3368
// ../protocol/examples/messageData/federation_tokens_exchange/federation_tokens_exchange.json

{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some unwanted spaces added here I guess

Comment on lines 3375 to 3376
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Comment on lines 3381 to 3382
// ../protocol/query/method/message/data/dataFederationTokensExchange.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@quadcopterman quadcopterman self-requested a review June 27, 2024 09:43
quadcopterman
quadcopterman previously approved these changes Jun 27, 2024
Copy link
Contributor

@quadcopterman quadcopterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Kaz-ookid
Copy link
Contributor Author

Kaz-ookid commented Jun 27, 2024

LGTM! You can even leave those spaces there it's not a big deal, the rest looks great

Actually those got added by #1950, my checks were failing and I was required to merge it. I don't know what this is about, I've never saw that. But if I remove those spaces, merge will be blocked. I'll let you merge once you've read this 👍

image

@matteosz matteosz added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 27, 2024
@Kaz-ookid Kaz-ookid enabled auto-merge June 27, 2024 11:11
…e2-maxime-roll-call-attendee-copy-button

# Conflicts:
#	fe2-android/app/src/main/res/layout/roll_call_fragment.xml
…ee-copy-button' into work-fe2-maxime-roll-call-attendee-copy-button
@Kaz-ookid Kaz-ookid dismissed stale reviews from quadcopterman and matteosz via e8bb9d1 June 27, 2024 11:16
Copy link

sonarcloud bot commented Jun 27, 2024

Copy link

sonarcloud bot commented Jun 27, 2024

Copy link

sonarcloud bot commented Jun 27, 2024

Copy link

sonarcloud bot commented Jun 27, 2024

@matteosz matteosz self-requested a review June 27, 2024 12:18
@Kaz-ookid Kaz-ookid added this pull request to the merge queue Jun 27, 2024
Merged via the queue into master with commit be8abce Jun 27, 2024
17 checks passed
@Kaz-ookid Kaz-ookid deleted the work-fe2-maxime-roll-call-attendee-copy-button branch June 27, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RollCall Attendee Token needs Copy to Clipboard Button
3 participants