-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added copy button in RollCall QR Token fragment #1949
added copy button in RollCall QR Token fragment #1949
Conversation
Pull reviewers statsStats of the last 30 days for popstellar:
|
🟠 There seems to be some formatting issues that must be applied from PR #1950 first. |
🟠 There seems to be some formatting issues that must be applied from PR #1950 first. |
…me-roll-call-attendee-copy-button Fixes by auto-format action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! You can even leave those spaces there it's not a big deal, the rest looks great
docs/messageData.md
Outdated
// ../protocol/examples/messageData/federation_tokens_exchange/federation_tokens_exchange.json | ||
|
||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some unwanted spaces added here I guess
docs/messageData.md
Outdated
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
docs/messageData.md
Outdated
// ../protocol/query/method/message/data/dataFederationTokensExchange.json | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Actually those got added by #1950, my checks were failing and I was required to merge it. I don't know what this is about, I've never saw that. But if I remove those spaces, merge will be blocked. I'll let you merge once you've read this 👍 |
…e2-maxime-roll-call-attendee-copy-button # Conflicts: # fe2-android/app/src/main/res/layout/roll_call_fragment.xml
…ee-copy-button' into work-fe2-maxime-roll-call-attendee-copy-button
Quality Gate passed for 'PoP - PoPCHA-Web-Client'Issues Measures |
Quality Gate passed for 'PoP - Be2-Scala'Issues Measures |
Quality Gate passed for 'PoP - Be1-Go'Issues Measures |
Quality Gate passed for 'PoP - Fe2-Android'Issues Measures |
addressing #1916
Added a copy to clipboard button next to the Token hash