Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE2] Clean Log #1948

Merged
merged 11 commits into from
Jun 27, 2024
Merged

[BE2] Clean Log #1948

merged 11 commits into from
Jun 27, 2024

Conversation

DanielTavaresA
Copy link
Collaborator

Previously logs were crowded with unintuitive messages and inconsistent over all code. Now logs should be simpler, more readable and contain only useful information

@DanielTavaresA DanielTavaresA requested a review from a team as a code owner June 26, 2024 14:02
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
20
▀▀▀▀▀
3d 30m
14
▀▀▀
arnauds5
🥈
6
7h
4
emonnin-epfl
🥉
4
8h 20m
8
▀▀
onsriahi14
3
1d 10h 51m
4
matteosz
3
1d 15h 22m
3
sgueissa
2
6h 58m
5
MariemBaccari
2
22h 39m
6
simone-kalbermatter
2
5h 32m
0
1florentin
1
19d 1h 53m
▀▀▀▀▀
0
quadcopterman
1
10d 7h 3m
▀▀▀
0
⚡️ Pull request stats

Copy link

🟠 There seems to be some formatting issues that must be applied from PR #1951 first.

Copy link

🟠 There seems to be some formatting issues that must be applied from PR #1951 first.

…el-clean-logs

Fixes by auto-format action
Copy link

sonarcloud bot commented Jun 27, 2024

Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Failed Quality Gate failed for 'PoP - Be2-Scala'

Failed conditions
58.8% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 27, 2024

Copy link

sonarcloud bot commented Jun 27, 2024

Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done !

@DanielTavaresA DanielTavaresA added this pull request to the merge queue Jun 27, 2024
Merged via the queue into master with commit d3c68fe Jun 27, 2024
16 of 17 checks passed
@DanielTavaresA DanielTavaresA deleted the work-be2-daniel-clean-logs branch June 27, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants