New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constants for feature paths #1701

Merged

simone-kalbermatter merged 3 commits into master from work-simone-feature-path-constants

Oct 30, 2023

Contributor

simone-kalbermatter commented Oct 15, 2023

Paths to features and scenarios that are used across features are now defined as constants in constants.feature.
This makes it easier to change paths in the future, as they will only have to be changed in one place. It also improves the readability of calls to call read(...) .


          define paths to scenarios in constants feature

fbce1b8

simone-kalbermatter added the prod-ready label

simone-kalbermatter self-assigned this

simone-kalbermatter requested a review from a team as a code owner

October 15, 2023 10:11

github-actions bot commented Oct 15, 2023

Pull reviewers stats

Stats of the last 30 days for popstellar:

	User	Total reviews	Time to review	Total comments
	pierluca 🥇	4 ▀▀▀▀	2d 8h 32m ▀	16 ▀▀▀▀▀▀▀▀
	K1li4nL 🥈	3 ▀▀▀	3d 14h 9m ▀	0
	jbsv 🥉	2 ▀▀	8d 1h 46m ▀▀▀	4 ▀▀
	simone-kalbermatter	1 ▀	9d 10h 40m ▀▀▀	1
	matteosz	1 ▀	5d 2h 48m ▀▀	0

simone-kalbermatter requested a review from matteosz

October 15, 2023 12:45

jbsv reviewed

View reviewed changes

Contributor

jbsv left a comment

Maybe some naming improvement ?

tests/karate/src/test/java/be/features/utils/constants.feature Outdated

+                  # Paths to scenarios defined in simpleScenarios
+                  * def simpleScenario = 'classpath:be/features/utils/simpleScenarios.feature@name='
+                  * def createLaoScenario = simpleScenario + 'valid_lao'
+                  * def createRollCallScenario = simpleScenario + 'valid_roll_call'

Contributor

jbsv Oct 16, 2023

I find create and valid quite different and a bit confusing. Shouldn't the valid_roll_call be renamed create_roll_call to avoid this confusion ? Other proposition ?

Contributor Author

simone-kalbermatter Oct 17, 2023

Good point, I forgot to change this.

simone-kalbermatter added 2 commits

October 17, 2023 10:38


          change scenario naming

3a40d10


          Merge branch 'master' of https://github.com/dedis/popstellar into wor…

d062927

…k-simone-feature-path-constants

sonarcloud bot commented Oct 29, 2023

[PoP - PoPCHA-Web-Client] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarcloud bot commented Oct 29, 2023

[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarcloud bot commented Oct 29, 2023

[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarcloud bot commented Oct 29, 2023

[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarcloud bot commented Oct 29, 2023

[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

simone-kalbermatter requested a review from jbsv

October 29, 2023 12:41

matteosz approved these changes

View reviewed changes

Contributor

matteosz left a comment

LGTM

simone-kalbermatter merged commit 6a8f1d8 into master

18 checks passed

simone-kalbermatter deleted the work-simone-feature-path-constants branch

October 30, 2023 22:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels