Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popcha on FE2 #1700

Merged
merged 12 commits into from
Nov 30, 2023
Merged

Popcha on FE2 #1700

merged 12 commits into from
Nov 30, 2023

Conversation

matteosz
Copy link
Contributor

@matteosz matteosz commented Oct 14, 2023 •
edited
Loading

Keep up with FE1 and implement PoPCHA also on FE2

@matteosz matteosz self-assigned this Oct 14, 2023
@matteosz matteosz changed the title Work fe2 matteo popcha Popcha on FE2 Oct 14, 2023
@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
pierluca
🥇		 4
▀▀▀▀		 2d 8h 32m
▀		 16
▀▀▀▀▀▀▀▀
K1li4nL
🥈		 3
▀▀▀		 3d 14h 9m
▀		 0
jbsv
🥉		 2
▀▀		 8d 1h 46m
▀▀▀		 4
▀▀
simone-kalbermatter
 1
▀		 9d 10h 40m
▀▀▀		 1
matteosz
 1
▀		 5d 2h 48m
▀▀		 0

@matteosz matteosz marked this pull request as ready for review October 25, 2023 21:37
@matteosz matteosz requested a review from a team as a code owner October 25, 2023 21:37
pierluca
pierluca reviewed Oct 28, 2023
View reviewed changes
Copy link
Contributor

@pierluca pierluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a partial review, only 15/23 files reviewed, but I won't have time to do more for now :)

...roid/app/src/main/java/com/github/dedis/popstellar/model/objects/security/Base64URLData.java Outdated Show resolved Hide resolved
fe2-android/app/src/main/java/com/github/dedis/popstellar/ui/qrcode/QrScannerFragment.java Outdated Show resolved Hide resolved
fe2-android/app/src/main/java/com/github/dedis/popstellar/utility/security/KeyManager.java Outdated Show resolved Hide resolved
...android/app/src/test/unit/java/com/github/dedis/popstellar/utility/MessageValidatorTest.java Outdated Show resolved Hide resolved
...ndroid/app/src/test/unit/java/com/github/dedis/popstellar/model/qrcode/PoPCHAQRCodeTest.java Show resolved Hide resolved
...thub/dedis/popstellar/model/network/method/message/data/popcha/PoPCHAAuthenticationTest.java Show resolved Hide resolved
pierluca
pierluca reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@pierluca pierluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions, but mostly LGTM :)

fe2-android/app/src/main/java/com/github/dedis/popstellar/ui/qrcode/ScanningAction.java Outdated Show resolved Hide resolved
...m/github/dedis/popstellar/model/network/method/message/data/popcha/PoPCHAAuthentication.java Show resolved Hide resolved
...rc/test/ui/robolectric/com/github/dedis/popstellar/ui/lao/popcha/PoPCHAHomeFragmentTest.java Outdated Show resolved Hide resolved
fe2-android/app/src/main/java/com/github/dedis/popstellar/ui/lao/LaoActivity.java Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2023

[PoP - PoPCHA-Web-Client] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2023

[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2023

[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2023

[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.3% 75.3% Coverage
0.0% 0.0% Duplication

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2023

[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jbsv
jbsv approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@jbsv jbsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierluca pierluca merged commit a288416 into master Nov 30, 2023
18 checks passed
@pierluca pierluca deleted the work-fe2-matteo-popcha branch November 30, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbsv jbsv jbsv approved these changes

@pierluca pierluca pierluca approved these changes

@simone-kalbermatter simone-kalbermatter Awaiting requested review from simone-kalbermatter

Assignees

@matteosz matteosz

Labels
fe2-android popcha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteosz @pierluca @jbsv