Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI java update #1692

Merged
merged 2 commits into from
Sep 30, 2023
Merged

CI java update #1692

merged 2 commits into from
Sep 30, 2023

Conversation

K1li4nL
Copy link
Contributor

@K1li4nL K1li4nL commented Sep 25, 2023

Java 11 will soon go unsupported on github CI. Java 17 should be good for at least 3 more years. The java requirement have been updated in the doc so that the CI env is closer to the local one.

@K1li4nL K1li4nL changed the title CI update CI java update Sep 25, 2023
@K1li4nL K1li4nL added be2-scala ci/cd continuous integration / continuous delivery labels Sep 25, 2023
pierluca
pierluca reviewed Sep 26, 2023
View reviewed changes
be2-scala/README.md Outdated
Comment on lines 98 to 99
# install java zulu 17
sdk install java 17.0.8-zulu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general question:
do we want to stick with the zulu distribution ?
https://sdkman.io/jdks

Copy link
Contributor Author

@K1li4nL K1li4nL Sep 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sot there is this website: https://whichjdk.com/

Given their opinion we should go preferably with Temurin but Zulu seems fine. As the website explains multiple companies are behind the Eclipse Foundation where Azul are the only one behind Zulu. Not depending on a single company is better so we can try switching to it, what do you think ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed !

@K1li4nL K1li4nL marked this pull request as ready for review September 27, 2023 06:24
@K1li4nL K1li4nL requested a review from a team as a code owner September 27, 2023 06:24
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

[PoP - PoPCHA-Web-Client] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@K1li4nL K1li4nL merged commit 7c26d49 into master Sep 30, 2023
18 checks passed
@K1li4nL K1li4nL deleted the work-be2-lauener-update-java branch September 30, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierluca pierluca pierluca left review comments

@matteosz matteosz matteosz approved these changes

Assignees
No one assigned
Labels
be2-scala ci/cd continuous integration / continuous delivery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@K1li4nL @pierluca @matteosz