Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for using SDK 17 on the CI #1691

Merged
merged 4 commits into from
Sep 30, 2023
Merged

Patch for using SDK 17 on the CI #1691

merged 4 commits into from
Sep 30, 2023

Conversation

matteosz
Copy link
Contributor

SDK11 will stop working soon on the CI

@matteosz matteosz self-assigned this Sep 24, 2023
@matteosz matteosz requested a review from a team as a code owner September 24, 2023 11:41
@matteosz matteosz added fe2-android ci/cd continuous integration / continuous delivery labels Sep 24, 2023
K1li4nL
K1li4nL previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will be doing the same for scala soon

@K1li4nL
Copy link
Contributor

K1li4nL commented Sep 25, 2023

I thought about this a bit late but the fe2 doc mentions java 11 for the setup, shouldn't it be corrected to java 17 so that the local env corresponds to the CI ?

@pierluca
Copy link
Contributor

@K1li4nL 's comment makes sense, I have to say 😅

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2023

[PoP - PoPCHA-Web-Client] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2023

[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2023

[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2023

[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2023

[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

K1li4nL
K1li4nL approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly checked the versions of the package + the CI built and ran everything correctly, I think we are good to go

@matteosz matteosz merged commit da72128 into master Sep 30, 2023
18 checks passed
@matteosz matteosz deleted the matteo-javapatch branch September 30, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1li4nL K1li4nL K1li4nL approved these changes

Assignees

@matteosz matteosz

Labels
ci/cd continuous integration / continuous delivery fe2-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteosz @K1li4nL @pierluca