Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make seed selectable & copyable #1359

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Tyratox
Copy link
Contributor

@Tyratox Tyratox commented Feb 1, 2023

Basically this reverts #1112, merge depending on what is decided.

Screenshot 2023-02-01 at 20 44 43

@Tyratox Tyratox self-assigned this Feb 1, 2023
@Tyratox Tyratox requested a review from a team as a code owner February 1, 2023 19:45
Not sure where this comes from actually
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@pierluca
Copy link
Contributor

pierluca commented Feb 6, 2023

@bford Hi Bryan,
This is arguable, you wanted the seed to be copy-pastable but there were strong arguments in #1112 against it.
Are those convincing enough for you, or do you really want the seed to be copy-pastable ?

@pierluca
Copy link
Contributor

Ping @bford

@pierluca pierluca requested a review from bford February 18, 2023 10:01
@Tyratox Tyratox requested review from osm-alt and removed request for osm-alt February 22, 2024 10:51
@CLAassistant
Copy link

CLAassistant commented Feb 27, 2024

CLA assistant check
All committers have signed the CLA.

@osm-alt
Copy link
Contributor

osm-alt commented Feb 28, 2024

I am getting an error when trying to run the fe1 of this branch on the web browser:
node:internal/crypto/hash:68
this[kHandle] = new _Hash(algorithm, xofLen);
^

Error: error:0308010C:digital envelope routines::unsupported
at new Hash (node:internal/crypto/hash:68:19)
at Object.createHash (node:crypto:138:10)
at module.exports (C:\Users....\popstellar\fe1-web\node_modules\webpack\lib\util\createHash.js:135:53)
at NormalModule._initBuildHash (C:\Users....\popstellar\fe1-web\node_modules\webpack\lib\NormalModule.js:417:16)
at handleParseError (C:\Users....\popstellar\fe1-web\node_modules\webpack\lib\NormalModule.js:471:10)
at C:\Users....\popstellar\fe1-web\node_modules\webpack\lib\NormalModule.js:503:5
at C:\Users....\popstellar\fe1-web\node_modules\webpack\lib\NormalModule.js:358:12
at C:\Users....\popstellar\fe1-web\node_modules\loader-runner\lib\LoaderRunner.js:373:3
at iterateNormalLoaders (C:\Users....\popstellar\fe1-web\node_modules\loader-runner\lib\LoaderRunner.js:214:10)
at Array. (C:\Users....\popstellar\fe1-web\node_modules\loader-runner\lib\LoaderRunner.js:205:4)
at Storage.finished (C:\Users....\popstellar\fe1-web\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:55:16)
at C:\Users....\popstellar\fe1-web\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:91:9
at C:\Users....\popstellar\fe1-web\node_modules\graceful-fs\graceful-fs.js:123:16
at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read/context:68:3) {
opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
library: 'digital envelope routines',
reason: 'unsupported',
code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants