Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: add support for DCR-USDT pair on /markets view #2002

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ukane-philemon
Copy link
Collaborator

@ukane-philemon ukane-philemon commented Aug 15, 2024

  • Add Mexc exchange DCR-USDT pair.
  • Add Binance DCR-USDT pair.

Breaking Changes:

1. `ratesproto`: Rate messages are no longer `DCR-BTC` only, a new `currencyPair` field indicates which market rate is sent.
  
`ExchangeSubscription` field changed from `btcIndex` to `index`.
2. `exchanges`: Aggregated chart data has been removed. This is because combining usdt and btc market bids and asks is not
   ideal and serves very little purpose. Each market has its own chart.
3. Renamed three fields on `exchanges.ExchangeBotState`:
     - `btc_index` -> `index`
     - `dcr_btc_exchanges` -> `dcr_exchanges` (this field now returns a nested map of supported markets)
     - `btc_indices` -> `indices` (this field now returns a nested map of supported indices)
4. Affected API Endpoints:
     -  `/exchangerate` (`exchanges.ExchangeRates.Exchanges` json field returns a nested map of support markets)
     -  `/exchanges` (returns modified `exchanges.ExchangeBotState`)
Screenshot 2024-08-15 at 3 05 01 AM

Closes #2001

@ukane-philemon
Copy link
Collaborator Author

ukane-philemon commented Sep 23, 2024

This PR sets the foundation for adding other pairs and exchanges. As per UI, we can always improve on that if there are suggestions. If a redesign is want we want, I can get that sorted.

- Add Mexc exchange `DCR-USDT` pair.
- Add Binance `DCR-USDT` pair.
- Fix minor bugs

Breaking Changes:

    1. `ratesproto`: Rate messages are no longer `DCR-BTC` only, a new `currencyPair` field indicates which market rate is sent.
      
`ExchangeSubscription` field changed from `btcIndex` to `index`.
    2. `exchanges`: Aggregated chart data has been removed. This is because combining usdt and btc market bids and asks is not
       ideal and serves very little purpose. Each market has its own chart.
    3. Renamed three fields on `exchanges.ExchangeBotState`:
         - `btc_index` -> `index`
         - `dcr_btc_exchanges` -> `dcr_exchanges` (this field now returns a nested map of supported markets)
         - `btc_indices` -> `indices` (this field now returns a nested map of supported indices)
    4. Affected API Endpoints:
         -  `/exchangerate` (`exchanges.ExchangeRates.Exchanges` json field returns a nested map of support markets)
         -  `/exchanges` (returns modified `exchanges.ExchangeBotState`)

Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decred Markets Page: Add Binance USDT Volume
1 participant