Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from turbolinks to turbo drive #1834

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chappjc
Copy link
Member

@chappjc chappjc commented Jun 8, 2021

This starts the migration from Turbolinks to Turbo Drive. Help needed.

We are using some wacky Turbolinks hacks to deal with url query and patge anchor navigation issues.

turbolinks/turbolinks#75 (comment)
The above is apparently no longer needed with Turbo Drive, but I don't follow how TurboQuery works or how to remove it. See hotwired/turbo#125

#845
#870
#814
#815

I'm pretty sure we need to nuke TurboQuery now, but someone else will need to pick this up.

@buck54321
Copy link
Member

Yuck.

Thanks for doing the footwork, @chappjc. I'll get into it.

@chappjc
Copy link
Member Author

chappjc commented Jun 9, 2021

Turns out a CSP with script-src set to self only (no more unsafe-inline) does not break with turbolinks after all. The change in #1832 was sufficient it seems. So I guess that makes this work super low priority. Maybe even could wait until the hotwired devs get turbo 7.0 out of beta.

@chappjc
Copy link
Member Author

chappjc commented Sep 30, 2021

Just saw that Turbo 7 was released a few days ago.
https://world.hey.com/hotwired/turbo-7-0dd7a27f
https://github.com/hotwired/turbo/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants