-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-organize and add iai-callgrind
benchmarks
#36
Merged
Merged
Commits on Sep 13, 2024
-
Modify fixed length key generator to return array
**Description** - Remove `rustc_hash` dependency - Have the fixed length key generator return an array instead of a boxed slice **Motivation** - Remove little-used dependency - Less memory usage by removing indirection of boxed slice, it shows up in the tests **Testing Done** `cargo test`
Configuration menu - View commit details
-
Copy full SHA for dfbf03a - Browse repository at this point
Copy the full SHA dfbf03aView commit details
Commits on Sep 14, 2024
-
**Description** Simplify the fixed-length key generator so it returns the expected number of keys, and no longer spreads the digits over the entire [0, 255] range. **Motivation** This fix was done so that I could generate similarly sized inputs for the benchmarks. **Testing Done** `cargo test`
Configuration menu - View commit details
-
Copy full SHA for 4d7d452 - Browse repository at this point
Copy the full SHA 4d7d452View commit details
Commits on Sep 15, 2024
-
Re-organize the criterion benchmarks
**Description** - Re-organize the criterion benchmarks into a nested structure with a single main entrypoint. - Convert a couple `debug_assert`s to `assert`s so that there is a consistent error message even in release mode **Motivation** I wanted to try and share benchmark definitions between criterion and iai-callgrind, but that didn't really pan out. This change is in-between and I like that there is only a single benchmark binary instead of one per-group. **Testing Done** `./scripts/full-test.sh nightly`
Configuration menu - View commit details
-
Copy full SHA for d27642c - Browse repository at this point
Copy the full SHA d27642cView commit details -
**Description** Add `iai-callgrind` benchmarks over the similar set of functions currently benchmarked by criterion. **Motivation** I like the `iai-callgrind` benchmarks because they are very precise and subsequent runs with no code change return mostly the same result. They also run fewer iterations than criterion, and generally take less time to run. This makes it easier to run them as part of the developing loop. **Testing Done** `./scripts/full-test.sh nightly`
Configuration menu - View commit details
-
Copy full SHA for 481019a - Browse repository at this point
Copy the full SHA 481019aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9855b63 - Browse repository at this point
Copy the full SHA 9855b63View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb62db5 - Browse repository at this point
Copy the full SHA fb62db5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35f1ede - Browse repository at this point
Copy the full SHA 35f1edeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 944f55c - Browse repository at this point
Copy the full SHA 944f55cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.