Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add image name validation rule for werf files #68

Merged
merged 3 commits into from
Jan 31, 2025
Merged

feat: add image name validation rule for werf files #68

merged 3 commits into from
Jan 31, 2025

Conversation

juev
Copy link
Member

@juev juev commented Jan 22, 2025

fixed: #60

example output:

🐒 [#images]
        Message - Image name format should be like `image: {{ .ModuleName }}/{{ .ImageName }}[-something]` in file: terraform-manager-yandex/werf.inc.yaml
                  broken lines:
                  image: terraform-provider-yandex
        Object  - terraform-manager-yandex/werf.inc.yaml
        Module  - terraform-manager

@juev juev requested review from yalosev and ldmonster January 22, 2025 12:15
@juev juev self-assigned this Jan 22, 2025
@juev juev marked this pull request as ready for review January 22, 2025 12:21
@juev juev force-pushed the feature/image-names branch 2 times, most recently from e3f9028 to 1d112ea Compare January 27, 2025 09:25
@juev juev force-pushed the feature/image-names branch from 1d112ea to e2eb2e7 Compare January 27, 2025 17:10
@juev juev merged commit f6d99e5 into main Jan 31, 2025
6 checks passed
@juev juev deleted the feature/image-names branch January 31, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldmonster ldmonster ldmonster approved these changes

@yalosev yalosev yalosev approved these changes

Assignees

@juev juev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

werf.inc.yaml image names
3 participants
@juev @yalosev @ldmonster