Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check readonly filesystem on containers #57

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

juev
Copy link
Member

@juev juev commented Jan 14, 2025

refactor: consolidate duplicate code
added checks for readonly filesystem on containers (fixed: deckhouse/deckhouse#4690)
remove panics

@juev juev requested a review from yalosev January 14, 2025 11:18
@juev juev self-assigned this Jan 14, 2025
@juev juev requested a review from ldmonster January 14, 2025 11:19
@juev
Copy link
Member Author

juev commented Jan 14, 2025

Checked locally, partial result:

🐒 [#k8s-resources]
        Message - Container's SecurityContext has `ReadOnlyRootFilesystem: false`, but it must be `true`
        Object  - kind = Deployment ; name = terraform-auto-converger ; namespace = d8-system ; container = converger
        Module  - terraform-manager

🐒 [#k8s-resources]
        Message - Container's SecurityContext has `ReadOnlyRootFilesystem: false`, but it must be `true`
        Object  - kind = Deployment ; name = terraform-state-exporter ; namespace = d8-system ; container = exporter
        Module  - terraform-manager

🐒 [#images]
        Message - Use `from:` or `fromImage:` and `final: false` directives instead of `artifact:` in the werf file
        Object  - /Users/devsyukov/src/github.com/deckhouse/deckhouse-test-modules/modules/500-upmeter/images/smoke-mini/werf.inc.yaml
        Module  - upmeter
        Value   - .Images.BASE_GOLANG_20_ALPINE

🐒 [#images]
        Message - Use `from:` or `fromImage:` and `final: false` directives instead of `artifact:` in the werf file
        Object  - /Users/devsyukov/src/github.com/deckhouse/deckhouse-test-modules/modules/500-upmeter/images/status/werf.inc.yaml
        Module  - upmeter
        Value   - node:14-alpine3.12@sha256:426384fb33a11d27dbbdc545f39bb8daacd3e7db7c60b52cd6bc0597e0045b8d

🐒 [#images]
        Message - Use `from:` or `fromImage:` and `final: false` directives instead of `artifact:` in the werf file
        Object  - /Users/devsyukov/src/github.com/deckhouse/deckhouse-test-modules/modules/500-upmeter/images/upmeter/werf.inc.yaml
        Module  - upmeter
        Value   - .Images.BASE_GOLANG_20_ALPINE

🐒 [#images]
        Message - Use `from:` or `fromImage:` and `final: false` directives instead of `artifact:` in the werf file
        Object  - /Users/devsyukov/src/github.com/deckhouse/deckhouse-test-modules/modules/500-upmeter/images/webui/werf.inc.yaml
        Module  - upmeter
        Value   - node:14-alpine3.12@sha256:426384fb33a11d27dbbdc545f39bb8daacd3e7db7c60b52cd6bc0597e0045b8d

🐒 [#k8s-resources]
        Message - Container's SecurityContext missing parameter ReadOnlyRootFilesystem
        Object  - kind = DaemonSet ; name = upmeter-agent ; namespace = d8-upmeter ; container = chown-volume-data
        Module  - upmeter

@juev juev marked this pull request as ready for review January 14, 2025 12:43
@juev juev requested a review from ldmonster January 20, 2025 09:48
@juev juev force-pushed the feature/ro-root-file-system branch from 7afb190 to 271e5cc Compare January 27, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[testing] Revise readonly filesystem and root user exclusions in matrix tests
3 participants