Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixing for releaser #6

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Bug fixing for releaser #6

merged 4 commits into from
Jul 16, 2024

Conversation

andreslucena
Copy link
Member

A couple bugs that I found when doing the last patch release that I had pending:

  • in v0.27 we still have the rake webpack script that needs to be run during the releases
  • the ByTitle (for checking the "New crowdin translations" PRs) wasn't working correctly. I refactored it to ByQuery to make it also more useful and not coupled to only that case
  • when running the rspec suite locally, it's fundamental to have the environment variables to detect i18n sanity issues not only with English but also with Spanish and Catalan (the mandatory languages for the releases)

alecslupu
alecslupu approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit e3ed6e8 into main Jul 16, 2024
1 check passed
@alecslupu alecslupu deleted the fix/details-v0.29 branch July 16, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecslupu alecslupu alecslupu approved these changes

Assignees

@alecslupu alecslupu

Labels
None yet
Projects
Maintainers' backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreslucena @alecslupu