Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't backup with 'msgmerge' in case LOCALEDIR is a .git repository. #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

twoixter
Copy link
Contributor

If the target $LOCALEDIR is in a GIT repository, there is no need for backups, you have to manually remove those *~ later.

@deceze
Copy link
Owner

deceze commented Jul 24, 2013

Hmm, meh... ;)

I'd solve this by adding "~ files" to .gitignore instead. Beyond that they don't bother me. Also, isn't it more likely for a parent of $LOCALEDIR to contain the .git file instead of $LOCALEDIR itself?

I agree though that they're redundant, so I'm not against this in general. Just make it more useful by checking for .git in parent directories?

@twoixter
Copy link
Contributor Author

Hehe. :-) Yes, I think the .gitignore is more of a personal taste, I prefer not to have the *~ files hanging around and just keep the .gitignore for files that must be present anyway (generated Makefiles or something like that).

You're right it's more useful to detect indeed if the directory is part of a repository, not only checking the parent but at any deep. I'll give a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants