Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

144 be able to save correlation matrix widget configuration #181

Merged

Conversation

FadyCoding
Copy link
Contributor

Describe your changes

Combined two issues into one ticket. Initial issue fixed by implementing getters and setters for the correlation matrix widget so it is saved successfully. Second issue was to update the configuration interface when saved.

Screenshots (if appropriate):

Issue ticket number and link

144
#144

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have increased the version number in the frontend/package.json and backend/swagger.yaml files
  • I have checked that Black, Flake8, Prettier and Cspell are passing

@FadyCoding FadyCoding linked an issue Mar 27, 2024 that may be closed by this pull request
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Fady BEKKAR seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Fady BEKKAR seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@FadyCoding FadyCoding self-assigned this Mar 27, 2024
Copy link
Member

@Tomansion Tomansion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@Tomansion Tomansion merged commit 77c234f into main Mar 27, 2024
9 of 10 checks passed
@Tomansion Tomansion deleted the 144-be-able-to-save-correlation-matrix-widget-configuration branch March 27, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Be able to save correlation matrix widget configuration
3 participants